Skip to content

correctly autolabel Documentation and Maintenance issues #18250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2020
Merged

correctly autolabel Documentation and Maintenance issues #18250

merged 1 commit into from
Aug 14, 2020

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Aug 14, 2020

PR Summary

Documentation and Maintenance issues were not automatically receiving the correct label on issue creation

@story645 my bad for missing this the first time around!

PR Checklist

  • na Has Pytest style unit tests
  • na Code is Flake 8 compliant
  • na New features are documented, with examples if plot related
  • na Documentation is sphinx and numpydoc compliant
  • na Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • na Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@ianhi ianhi mentioned this pull request Aug 14, 2020
Closed
story645
story645 approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and it's on us for not catching it in the initial review 😅

@QuLogic QuLogic added this to the v3.4.0 milestone Aug 14, 2020
@QuLogic
Copy link
Member

QuLogic commented Aug 14, 2020

Not going to worry about CI here.

@QuLogic QuLogic merged commit d9fd7f9 into matplotlib:master Aug 14, 2020
@ianhi ianhi deleted the fix-auto-label branch August 14, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ianhi @QuLogic @story645