Skip to content

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 19, 2020

PR Summary

Previously, reviewdog would filter flake8 issues outside the diff. This caused issues like unused imports to be ignored, and the filtering was disabled. A recently merged PR was only linted before that switch, and so an unused import slipped in.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymak jklymak merged commit 5703ac4 into matplotlib:master Aug 19, 2020
@jklymak
Copy link
Member

jklymak commented Aug 19, 2020

Just merged to unbreak CI - and its a trivial change...

@QuLogic QuLogic deleted the unused-import branch August 19, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants