Skip to content

Soft-deprecate Axes.plot_date() #18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2021
Merged

Soft-deprecate Axes.plot_date() #18346

merged 3 commits into from
May 8, 2021

Conversation

timhoffm
Copy link
Member

PR Summary

Closes #18154.

story645
story645 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there also gonna be a DeprecationWarning?

@timhoffm
Copy link
Member Author

timhoffm commented Aug 24, 2020 •
edited
Loading

Yes, it's a little late here ...

I've made this a pending deprecation, which feels a bit better than a very long deprecation period.

--> Means we'll still have to deprecate explicitly in a later version.

@timhoffm timhoffm force-pushed the plot_date branch 2 times, most recently from 2580646 to de6a915 Compare August 25, 2020 21:00
tacaswell
tacaswell previously requested changes Aug 28, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in principle, but I think that this need a note in the API changes page.

@timhoffm timhoffm mentioned this pull request Feb 26, 2021
Merged
7 tasks
@timhoffm timhoffm dismissed tacaswell’s stale review April 25, 2021 21:53

Added note on API changes page.

dstansby
dstansby requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, I approved before seeing the CI, that should probably be fixed! 👍 in theory though

@timhoffm timhoffm force-pushed the plot_date branch 2 times, most recently from 4545764 to bcae8a7 Compare April 26, 2021 20:29
@timhoffm
Copy link
Member Author

PendingDeprecationWarning was not playing nicely with sphinx (warnings causing sphinx to fail). I suppose we'd have to include special handing for that.

Instead of a PendingDeprecationWarning I went back to only discouraging this code. In both cases we'd have to add a DeprecationWarning to later releases if we want to finally remove it. So there's no real benefit of the pending deprecation warning.

@timhoffm
Copy link
Member Author

Macos test failure seems unrelated (subprocess timed out).

@jklymak jklymak requested a review from dstansby May 8, 2021 20:45
@jklymak
Copy link
Member

jklymak commented May 8, 2021

@dstansby I think that CI is happier now...

@jklymak jklymak merged commit ee6a42f into matplotlib:master May 8, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone May 10, 2021
@timhoffm timhoffm deleted the plot_date branch June 10, 2022 21:19
@ksunden ksunden mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@story645 story645 story645 approved these changes

@dstansby dstansby dstansby approved these changes

@tacaswell tacaswell tacaswell left review comments

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Deprecate plot_date()
6 participants
@timhoffm @jklymak @tacaswell @story645 @dstansby @QuLogic