Skip to content

Remove redundant angles in ellipse demo. #18349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 25, 2020

PR Summary

Since ellipses are 180°-symmetric, they're actually overplotted twice (and 3 times for 0° before #16109.)

Apparently, I committed this ages ago and forgot to PR it.

PR Checklist

  • [n/a] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

Since ellipses are 180°-symmetric, they're actually overplotted twice
(and 3 times for 0° before matplotlib#16109.)
@QuLogic QuLogic added this to the v3.4.0 milestone Aug 25, 2020
@jklymak jklymak merged commit 309b6ea into matplotlib:master Aug 25, 2020
@QuLogic QuLogic deleted the ellipse-demo branch August 25, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants