Skip to content

nbagg: Store DPI ratio on figure instead of window. #18361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

nbagg: Store DPI ratio on figure instead of window. #18361

merged 1 commit into from
Aug 28, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 27, 2020

PR Summary

This prevents existing figures from breaking if a followup figure fails to initialize its canvas and overwrites the (global) window ratio.

See #17576 (comment).

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
nbagg: Store DPI ratio on figure instead of window.
3c0ded7 
This prevents existing figures from breaking if a followup figure fails
to initialize its canvas and overwrites the (global) window ratio.

See matplotlib#17576 (comment).
@tacaswell tacaswell added this to the v3.4.0 milestone Aug 28, 2020
@tacaswell tacaswell merged commit 705a140 into matplotlib:master Aug 28, 2020
@QuLogic QuLogic deleted the nbagg-fig-ratio branch August 28, 2020 21:30
@tacaswell tacaswell modified the milestones: v3.4.0, v3.3.2 Sep 14, 2020
@tacaswell
Copy link
Member

Manually cherry-picking to make backporting #18454 easier.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Sep 14, 2020
@tacaswell
Merge pull request matplotlib#18361 from QuLogic/nbagg-fig-ratio
eea9f63 
FIX: Store DPI ratio on figure instead of window for nbagg/webagg
@tacaswell tacaswell mentioned this pull request Sep 14, 2020
Merged
@QuLogic QuLogic mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: nbagg GUI: webagg
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @timhoffm