Skip to content

Avoid demo'ing passing kwargs to gca(). #18419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2020
Merged

Avoid demo'ing passing kwargs to gca(). #18419

merged 1 commit into from
Sep 7, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 6, 2020

Creating a new Axes with kwargs is better done with add_subplot().

(gca(**...) is still present in a few tests that explicitly test that
functionality.)

xref #10700.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Avoid demo'ing passing kwargs to gca().
73d51ad 
Creating a new Axes with kwargs is better done with `add_subplot()`.

(`gca(**...)` is still present in a few tests that explicitly test that
functionality.)
@anntzer anntzer added this to the v3.4.0 milestone Sep 6, 2020
@jklymak jklymak merged commit 2c265ed into matplotlib:master Sep 7, 2020
@anntzer anntzer deleted the ungcakw branch September 7, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm