Skip to content

Correct link to widgets examples #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Correct link to widgets examples #18473

merged 1 commit into from
Sep 14, 2020

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Sep 14, 2020

PR Summary

Currently clicking the widgets examples link on the sample plots page puts you at the top of the page rather than the at the widgets examples section. This changes it so you are placed at the correct section.
You can find the offending link here: https://matplotlib.org/3.3.1/tutorials/introductory/sample_plots.html#gui-widgets
image
which then leads to here:
https://matplotlib.org/3.3.1/gallery/index.html

instead of
https://matplotlib.org/3.3.1/gallery/index.html#widgets

PR Checklist

  • na Has pytest style unit tests (and pytest passes).
  • na Is Flake 8 compliant (run flake8 on changed files to check).
  • na New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • na Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • na New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • na API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Merged cause all the docs building tests passed.

@story645 story645 merged commit 3d75230 into matplotlib:master Sep 14, 2020
@ianhi ianhi deleted the link-fix branch September 14, 2020 15:21
@QuLogic QuLogic added this to the v3.4.0 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants