Inline ScalarFormatter._formatSciNotation. #18506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Sep 18, 2020
|
The doc error looks real to me... |
QuLogic
reviewed
Sep 18, 2020
It's only used in one place, in a tiny function, and doesn't have a particularly intuitive name, so it's actually easier to follow the logic by having it all in one place. Moreover the implementation can be greatly simplified by separately computing and formatting the mantissa and the exponent, rather than trying to parse the locale-dependent result of the formatting of the entire number.
QuLogic
approved these changes
Sep 18, 2020
StefRe
added a commit
to StefRe/matplotlib
that referenced
this pull request
Dec 29, 2021
Fix regression in 3.4.0 introduced by b5fb685 (matplotlib#18506).
This was referenced Dec 29, 2021
scottshambaugh
pushed a commit
to scottshambaugh/matplotlib
that referenced
this pull request
Jan 6, 2022
Fix regression in 3.4.0 introduced by b5fb685 (matplotlib#18506).
|
Hello, |
|
@vpicouet please ask usage questions at discourse.matplotlib.org. However this is as a private method so it was not meant to be used by downstream users. You could look at the source and copy it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only used in one place, in a tiny function, and doesn't have a
particularly intuitive name, so it's actually easier to follow the logic
by having it all in one place. Moreover the implementation can be
greatly simplified by separately computing and formatting the mantissa
and the exponent, rather than trying to parse the locale-dependent
result of the formatting of the entire number.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).