Skip to content

Add Text3D position getter/setter #18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2020
Merged

Add Text3D position getter/setter #18525

merged 2 commits into from
Sep 23, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 19, 2020

PR Summary

And simplify the calculations to avoid the duplicate position.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.0 milestone Sep 19, 2020
@QuLogic
Copy link
Member Author

QuLogic commented Sep 19, 2020 •
edited
Loading

This could maybe do with a What's new entry, but I'd rather finish this sort of change on all the other artists and write one up then (i.e., roll it up into #18189.)

timhoffm
timhoffm reviewed Sep 19, 2020
View reviewed changes
@QuLogic QuLogic force-pushed the text3d-simplification branch from 5cf501e to e16460f Compare September 22, 2020 02:16
dopplershift
dopplershift approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the change to get_dir_vector's return value is an API change. Do we need a notice for a function so minor?

@QuLogic
Simplify implementation of Text3D.
6c0c30b 
This avoids saving a second copy of the whole position, and the
inconsistencies that might arise thereof.
@QuLogic
Add getter/setter for Text3D position.
7034b70
@QuLogic QuLogic force-pushed the text3d-simplification branch from e16460f to 7034b70 Compare September 23, 2020 00:54
@dopplershift dopplershift merged commit 5b835ee into matplotlib:master Sep 23, 2020
@QuLogic QuLogic deleted the text3d-simplification branch September 23, 2020 02:03
@QuLogic QuLogic mentioned this pull request Mar 2, 2021
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @dopplershift @timhoffm