Skip to content

Documentation improvements for stairs() #18543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

timhoffm
Copy link
Member

PR Summary

Addresses bullet points 1 and 3 of #18275 (review):

  • Comparison of .pyplot.step and .pyplot.stairs could use some explanatory text.
  • Some docstring parameters don't have a description. Even if they state something apparently obvious, they should be explicit.

@timhoffm timhoffm added this to the v3.4.0 milestone Sep 22, 2020
@timhoffm timhoffm changed the title Stairs Documentation improvements for stairs() Sep 22, 2020
@jklymak
Copy link
Member

jklymak commented Sep 22, 2020

pinging @andrzejnovak, in case they see any issues. But this looks good to me...

@andrzejnovak
Copy link
Contributor

Thanks, LGTM.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge once CI is happy....

@jklymak jklymak merged commit f4982f1 into matplotlib:master Sep 22, 2020
@timhoffm timhoffm deleted the stairs branch September 22, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants