-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: unit-convert pcolorargs before interpolating #18549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: unit-convert pcolorargs before interpolating #18549
Conversation
d471a21
to
9a1af30
Compare
7c0711c
to
9474ee6
Compare
9474ee6
to
75097a2
Compare
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
I can do the back port. Its a bit of a PITA because we changed the unit handling for 3.4 but not 3.3.x.... |
…t-before-interp FIX: unit-convert pcolorargs before interpolating
PR Summary
Closes #18547
For
pcolor(mesh)
the new "nearest" interpolation was being done before unit conversion, so datetime (for instance) did not work. This moves unit conversion inside_pcolorargs
.failed before, and works now...
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
andpydocstyle<4
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).