Change subplot(111, ...) to subplot(...) as 111 is the default. #18552

timhoffm · 2020-09-23T22:56:11Z

Partly re-does #17335.

Doing everything in one action seems a bit much since every occurrence must be checked. There some rare cases in which we want to leave the numbers in or want to do something else.

All changes are either in tutorials/examples, docstrings, comments or tests.

story645

Some questions out of curiosity but they're not blockers

lib/matplotlib/figure.py

story645 · 2020-09-23T23:07:46Z

tutorials/introductory/pyplot.py

@@ -259,7 +259,7 @@ def f(t):

 ###############################################################################
 # The `~.pyplot.figure` call here is optional because
-# ``figure(1)`` will be created by default, just as a ``subplot(111)``
+# ``figure(1)`` will be created by default, just as a ``subplot()``


Does this need the figure(1)

No. I've rewritten the sentence to make more sense. But don't get me started, otherwise I'll rewrite the whole tutorial 😝.

timhoffm added the Documentation label Sep 23, 2020

timhoffm added this to the v3.4.0 milestone Sep 23, 2020

timhoffm added the Maintenance label Sep 23, 2020

story645 approved these changes Sep 23, 2020

View reviewed changes

timhoffm force-pushed the doc-subplots branch from 44da50e to 52b7555 Compare September 23, 2020 23:44

Change subplot(111, ...) to subplot(...) as 111 is the default.

4d6bba5

timhoffm force-pushed the doc-subplots branch from 52b7555 to 4d6bba5 Compare September 23, 2020 23:47

story645 merged commit 3e88c9f into matplotlib:master Sep 24, 2020

timhoffm deleted the doc-subplots branch September 24, 2020 06:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change subplot(111, ...) to subplot(...) as 111 is the default. #18552

Change subplot(111, ...) to subplot(...) as 111 is the default. #18552

timhoffm commented Sep 23, 2020 •

edited

Loading

story645 left a comment

story645 Sep 23, 2020

timhoffm Sep 23, 2020

Change *subplot(111, ...) to *subplot(...) as 111 is the default. #18552

Change *subplot(111, ...) to *subplot(...) as 111 is the default. #18552

Conversation

timhoffm commented Sep 23, 2020 • edited Loading

story645 left a comment

Choose a reason for hiding this comment

story645 Sep 23, 2020

Choose a reason for hiding this comment

timhoffm Sep 23, 2020

Choose a reason for hiding this comment

Change subplot(111, ...) to subplot(...) as 111 is the default. #18552

Change subplot(111, ...) to subplot(...) as 111 is the default. #18552

timhoffm commented Sep 23, 2020 •

edited

Loading