Skip to content

Simplify wx rubberband drawing. #18599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Simplify wx rubberband drawing. #18599

merged 1 commit into from
Oct 11, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 28, 2020

Like for qt/gtk, it's much easier to just draw the rectangle at
gui_repaint time.

AFAICT this now works on Wayland too, and closes the rubberbanding part of #10417 / #11944.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Like for qt/gtk, it's much easier to just draw the rectangle at
gui_repaint time.

AFAICT this now works on Wayland too.
@tacaswell tacaswell added this to the v3.4.0 milestone Oct 2, 2020
@QuLogic QuLogic mentioned this pull request Oct 7, 2020
7 tasks
@timhoffm timhoffm merged commit 84b14c7 into matplotlib:master Oct 11, 2020
@anntzer anntzer deleted the wxrub branch October 11, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants