Simplify Rectangle and RegularPolygon. #18601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess caching may be nice but wouldn't worry about it unless someone shows that this is an actual bottleneck; also in any case this PR doesn't regress on that... |
|
That's true for |
|
RegularPolygon calls |
|
Yes, but someone could call fig, ax = plt.subplots()
rp = mpatches.RegularPolygon((0, 2), 3)
ax.add_patch(rp)
ax.text(0, 0, 'Center', ha='center', va='center', transform=rp.get_transform())
rp.xy = (3, 5)
ax.set_xlim(-10, 10)
ax.set_ylim(-10, 10) |
dopplershift
approved these changes
Sep 29, 2020
In Rectangle: no need to keep track and update of `self._x1` and `self._x2` all the time, just when we compute the patch_transform (which doesn't need to be split out into its own function, or stored into an instance variable, given that it's never accessed via the private attribute name). In RegularPolygon: likewise, we can just compute the transform in get_patch_transform(), and nowhere else, so the other attributes can just be plain attributes instead of properties that update the transform all the time.
|
Fair point re: RegularPolygon.get_patch_transform; fixed. |
QuLogic
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rectangle: no need to keep track and update of
self._x1andself._x2all the time, just when we compute the patch_transform(which doesn't need to be split out into its own function, or stored
into an instance variable, given that it's never accessed via the
private attribute name).
In RegularPolygon: likewise, we can just compute the transform in
get_patch_transform(), and nowhere else, so the other attributes can
just be plain attributes instead of properties that update the transform
all the time.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).