Provide a 'cursive' font present in Windows' default font set. #18623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changelog. Admittedly the CSS example page is inconsistent with https://www.w3.org/TR/css-fonts-3/#generic-font-families which lists Comic Sans as *fantasy*, not *cursive*, but none of the other cursive fonts listed here is readily available. fontconfig also defaults to listing Comic Sans as cursive. The main intent is to make `text_labels_and_annotations/fonts_demo.py` runnable with no warnings if MS core fonts are installed (freely available and packaged on Linux e.g. as https://packages.debian.org/sid/ttf-mscorefonts-installer); in any case if someone really wants a cursive or fantasy font they'll likely have to pass the actual font family name anyways as there's too much variation in what "cursive" or "fantasy" means... (The original list of fonts comes from 41f1c49 but is not explained.)
tacaswell
approved these changes
Oct 1, 2020
dopplershift
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog. Admittedly the CSS example page is inconsistent with
https://www.w3.org/TR/css-fonts-3/#generic-font-families which lists
Comic Sans as fantasy, not cursive, but none of the other cursive
fonts listed here is readily available. fontconfig also defaults to
listing Comic Sans as cursive (https://gitlab.freedesktop.org/fontconfig/fontconfig/-/blob/master/conf.d/60-latin.conf#L68).
The main intent is to make
text_labels_and_annotations/fonts_demo.pyrunnable with no warnings (#18615) if MS core fonts are installed (freely
available and packaged on Linux e.g. as
https://packages.debian.org/sid/ttf-mscorefonts-installer); in any case
if someone really wants a cursive or fantasy font they'll likely have to
pass the actual font family name anyways as there's too much variation
in what "cursive" or "fantasy" means...
(The original list of fonts comes from 41f1c49 but is not explained.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).