Simplify Colorbar.set_label, inline Colorbar._edges. #18645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set_label` can just forward everything to either `set_xlabel` or `set_ylabel`, which already have all the logic for handling `loc`, instead of duplicating that logic. `_edges` is really just a call to `np.dstack`, and factoring it to a separate function doesn't really help legibility.
timhoffm
approved these changes
Oct 3, 2020
jklymak
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_labelcan just forward everything to eitherset_xlabelorset_ylabel, which already have all the logic for handlingloc,instead of duplicating that logic.
_edgesis really just a call tonp.dstack, and factoring it to aseparate function doesn't really help legibility.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).