fix: keep baseline scale to baseline 0 even if set to None #18663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's not really the intended semantics of sticky_edges. In particular, it's not even clear to me what behavior you expect if there are multiple sticky edges (do you expand to include all of them? that's not what the current implementation does, at least). |
|
Thanks @anntzer that works much better. |
|
Could you add some kind of test for this? |
|
@dopplershift fixed |
|
bump, the codecov report seems to complain about unrelated stuff |
dopplershift
approved these changes
Oct 12, 2020
timhoffm
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Ok hopefully last follow up on #18579. The current setup, unfortunately, ignores stickies when
baseline=NoneUpdating datalim as well fixes this. Thanks @anntzer
@timhoffm @jklymak
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).