Skip to content

Cleanup sample_data. #18691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Cleanup sample_data. #18691

merged 1 commit into from
Oct 9, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 8, 2020

  • No need to have both Google's and Apple's stock prices, one is enough.
  • Replace ada.png (used once only) and grace_hopper.png by the 10x
    smaller grace_hopper.jpg.
  • Replace ct.raw.gz (CT scan example) by s1045.ima.gz (MRI example,
    smaller).
  • Remove unused None_vs_nearest-pdf.png (see also d35fc38), demodata.csv
    (there's still msft.csv as example csv file).

Overall this make the sample_data directory ~4x smaller (down to 500K,
which is smaller than nearly all the extension modules); we can perhaps
now consider always shipping sample_data with Matplotlib instead of
having its presence controlled by a flag.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member

QuLogic commented Oct 8, 2020

When we previously removed things from sample data, it got an API change note, so these need one too.

- No need to have both Google's and Apple's stock prices, one is enough.
- Replace ada.png (used once only) and grace_hopper.png by the 10x
  smaller grace_hopper.jpg.
- Replace ct.raw.gz (CT scan example) by s1045.ima.gz (MRI example,
  smaller).
- Remove unused None_vs_nearest-pdf.png (see also d35fc38), demodata.csv
  (there's still msft.csv as example csv file).

Overall this make the sample_data directory ~4x smaller (down to 500K,
which is smaller than nearly all the extension modules); we can perhaps
now consider always shipping sample_data with Matplotlib instead of
having its presence controlled by a flag.
@anntzer
Copy link
Contributor Author

anntzer commented Oct 9, 2020

done

@QuLogic QuLogic merged commit e629aff into matplotlib:master Oct 9, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Oct 9, 2020
@anntzer anntzer deleted the usd branch October 10, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants