Deprecate cla() methods of Axis and Spines in favor of clear() #18710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e120ce to
d3e4731
Compare
d3e4731 to
f13cc98
Compare
QuLogic
approved these changes
Oct 13, 2020
dopplershift
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The name
cla()is largely unintuitive up to misleading, becausecla()originates frompyplot.cla()"clear axes". I assume clearing Axis and Spines directly is rarely done on the user-side and thus expect that the deprecation largely won't affect users, but will make our internal code a bit more readable.