Add a ponyfill for ResizeObserver on older browsers. #18732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes nbagg on Firefox ESR. Fixes matplotlib#18481.
|
I had to set layout.css.resizeobserver.enabled to false (because the ESR from arch defaults to true :table flip:), but confirm that this fixes the problem and does not break it in a chrome-derivative or firefox ESR with the feature turned on. Going to make an executive decision and merge this on one review. |
tacaswell
approved these changes
Nov 10, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 10, 2020
QuLogic
added a commit
that referenced
this pull request
Nov 10, 2020
…732-on-v3.3.x Backport PR #18732 on branch v3.3.x (Add a ponyfill for ResizeObserver on older browsers.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes nbagg on Firefox ESR.
Fixes #18481.
Note, the embedded
ResizeObserverponyfill is slightly edited to fix jsxtools/frontend#4, so if you re-run the embedding script, you won't get exactly the code that's in this PR. I sent a PR upstream so it should be fixed for the next release.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).