Skip to content

Building Matplotlib on Ubuntu #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2013
Merged

Building Matplotlib on Ubuntu #1874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
571e7e0
Fix bug where basedirlist was treated as a single string
mdboom Apr 1, 2013
31c880f
Strip each entry of basedirlist
mdboom Apr 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix bug where basedirlist was treated as a single string
  • Loading branch information
@mdboom
mdboom committed Apr 1, 2013
commit 571e7e01f65fae74f2f4308cd77bf9ed3fe9d144
2 changes: 1 addition & 1 deletion setup.cfg.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[directories]
# Uncomment to override the default basedir in setupext.py.
# This can be a single directory or a space-delimited list of directories.
# This can be a single directory or a comma-delimited list of directories.
#basedirlist = /usr

[status]
Expand Down
2 changes: 1 addition & 1 deletion setupext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def check_output(*popenargs, **kwargs):
pass

try:
options['basedirlist'] = config.get("directories", "basedirlist")
options['basedirlist'] = config.get("directories", "basedirlist").split(',')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to strip it? I'd have put something like /usr, /usr/local (notice the space after the comma)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Stripping would be a good idea.

except:
pass
else:
Expand Down