Skip to content

Remove several more deprecations #18753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 16, 2020

PR Summary

Deprecated in 3.2 or earlier, so removal will be in 3.4.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.0 milestone Oct 16, 2020
@@ -57,8 +57,7 @@ The following API elements have been removed:
instead)
- ``axisartist.axes_divider.Axes``, ``axisartist.axes_divider.LocatableAxes``
(use ``axisartist.axislines.Axes`` instead)
- the ``normed`` kwarg to ``hist`` (use ``density`` instead)
- the ``verts`` parameter to ``scatter`` (use ``marker`` instead)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this was incorrectly documented as removed, but it was only deprecated.

@QuLogic QuLogic force-pushed the remove-deprecations branch 3 times, most recently from 4bde473 to c1f5a3a Compare October 16, 2020 23:11
@QuLogic QuLogic added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 20, 2020
@QuLogic QuLogic mentioned this pull request Oct 27, 2020
@QuLogic QuLogic force-pushed the remove-deprecations branch from ed9bd5b to 8b8f446 Compare October 27, 2020 03:01
@timhoffm
Copy link
Member

@QuLogic I've done a rebase here https://github.com/timhoffm/matplotlib/tree/remove-deprecations. It's only trivial stuff, but I don't want to force push over your commits.

@tacaswell tacaswell merged commit 03a3d21 into matplotlib:master Dec 16, 2020
@QuLogic QuLogic deleted the remove-deprecations branch December 16, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants