Skip to content

Backport PR #18754 on branch v3.3.x (FIX: make sure we have more than 1 tick with small log ranges) #18786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Backport PR #18754 on branch v3.3.x (FIX: make sure we have more than 1 tick with small log ranges) #18786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/matplotlib/tests/test_ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,3 +1347,13 @@ def test_bad_locator_subs(sub):
ll = mticker.LogLocator()
with pytest.raises(ValueError):
ll.subs(sub)


@pytest.mark.parametrize('numticks', [1, 2, 3, 9])
@pytest.mark.style('default')
def test_small_range_loglocator(numticks):
ll = mticker.LogLocator()
ll.set_params(numticks=numticks)
for top in [5, 7, 9, 11, 15, 50, 100, 1000]:
ticks = ll.tick_values(.5, top)
assert (np.diff(np.log10(ll.tick_values(6, 150))) == 1).all()
7 changes: 7 additions & 0 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,6 +2500,13 @@ def tick_values(self, vmin, vmax):
if mpl.rcParams['_internal.classic_mode'] else
(numdec + 1) // numticks + 1)

# if we have decided that the stride is as big or bigger than
# the range, clip the stride back to the available range - 1
# with a floor of 1. This prevents getting axis with only 1 tick
# visible.
if stride >= numdec:
stride = max(1, numdec - 1)

# Does subs include anything other than 1? Essentially a hack to know
# whether we're a major or a minor locator.
have_subs = len(subs) > 1 or (len(subs) == 1 and subs[0] != 1.0)
Expand Down