Cleanup interactive pan/zoom. #18847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 30, 2020
timhoffm
reviewed
Oct 30, 2020
timhoffm
approved these changes
Oct 31, 2020
|
I don't know what's wrong with Azure; maybe a rebase is needed? |
Store all the relevant state in a single namedtuple (`_pan_info`), similar to the one used for zoom (`_zoom_info`), instead of scattering it in two attributes (`_button_pressed`/`_xypress`). Slightly reorder logic in `press_pan` to match the order in `press_zoom`; likewise sync `release_pan` with `release_zoom`. We don't need to store the axes index (as was done in `_xypress`). In `release_zoom`, move the less-than-5px check out of the loop, as it only needs to be done once.
|
namedtuple it is, then. |
QuLogic
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store all the relevant state in a single dict (
_pan_info), similarto the one used for zoom (
_zoom_info), instead of scattering itin two attributes (
_button_pressed/_xypress). Slightly reorderlogic in
press_panto match the order inpress_zoom; likewise syncrelease_panwithrelease_zoom.We don't need to store the axes index (as was done in
_xypress).In
release_zoom, move the less-than-5px check out of the loop, as itonly needs to be done once.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).