Skip to content

Improve pgf special escapes. #18856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 31, 2020

  • In common_texification.py, when splitting math and non-math segments,
    match two dollar signs surrounding a math segment rather than single
    dollar signs; this lets us correctly handle e.g. $2 which we
    explicitly support in other backends as being plain text, not
    unbalanced math (the previous implementation would handle that as
    math).
  • Instead of adding \displaystyle in front of each and every math block,
    use the TeX-provided \everymath mechanism to just register that
    once (this basically auto-prepends \displaystyle before every math
    block).
  • Define \mathdefault as a noop (which is consistent with what
    texmanager does) instead of stripping it out, which would allow e.g.
    for the possibility that someone redefines \mathdefault in whatever
    way they want.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.4.0 milestone Oct 31, 2020
@anntzer anntzer force-pushed the pgfsplit branch 2 times, most recently from ecc437b to f6a00a0 Compare November 1, 2020 11:00
@anntzer anntzer marked this pull request as draft November 1, 2020 11:00
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 21, 2021
@tacaswell tacaswell modified the milestones: v3.5.0, v3.6.0 Aug 5, 2021
- In common_texification.py, when splitting math and non-math segments,
  match *two* dollar signs surrounding a math segment rather than single
  dollar signs; this lets us correctly handle e.g. `$2` which we
  explicitly support in other backends as being plain text, not
  unbalanced math (the previous implementation would handle that as
  math).
- Instead of adding `\displaystyle` in front of each and every math block,
  use the TeX-provided `\everymath` mechanism to just register that
  once (this basically auto-prepends `\displaystyle` before every math
  block).
- Define `\mathdefault` as a noop (which is consistent with what
  texmanager does) instead of stripping it out, which would allow e.g.
  for the possibility that someone redefines `\mathdefault` in whatever
  way they want.
@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
@anntzer
Copy link
Contributor Author

anntzer commented Jul 19, 2022

Superseded by #23442.

@anntzer anntzer closed this Jul 19, 2022
@anntzer anntzer deleted the pgfsplit branch July 19, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants