Add dependency on ucs for pgf tests using [utf8x]{inputenc}. #18872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Nov 2, 2020
| @@ -153,6 +153,10 @@ def test_rcupdate(): | |||
| '\\usepackage{sfmath}')}] | |||
| tol = [6, 0] | |||
| for i, rc_set in enumerate(rc_sets): | |||
| if i == 1: | |||
There was a problem hiding this comment.
Less magical:
Suggested change
| if i == 1: | |
| if 'utf8x' in rc_set.get('pgf.preamble', ''): |
There was a problem hiding this comment.
good idea, went for a variant of it.
`ucs` is a dependency of `\usepackage[utf8x]{inputenc}`, but if it
is absent we fail later with the slightly confusing error message
"Keyboard character used is undefined in inputencoding `utf8x'" (as
can be observed by temporarily uninstalling `ucs`). Instead, make
the dependency explicit. Also, in test_rcupdate, only one of the two
iterations uses `[utf8x]{inputenc}`, so run the other iteration first
(giving it a chance to fail) and skip the test only at the second
iteration if needed.
tacaswell
reviewed
Nov 2, 2020
| @@ -113,6 +113,7 @@ def test_xelatex(): | |||
|
|
|||
| # test compiling a figure to pdf with pdflatex | |||
| @needs_pdflatex | |||
| @pytest.mark.skipif(not _has_tex_package('ucs'), reason='needs ucs.sty') | |||
There was a problem hiding this comment.
did you mean to remove this line?
There was a problem hiding this comment.
no? that test also needs ucs (and it's a single figure test so we can just use the decorator form)
timhoffm
approved these changes
Nov 2, 2020
QuLogic
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ucsis a dependency of\usepackage[utf8x]{inputenc}, but if itis absent we fail later with the slightly confusing error message
"Keyboard character used is undefined in inputencoding
utf8x'" (as can be observed by temporarily uninstallingucs). Instead, make the dependency explicit. Also, in test_rcupdate, only one of the two iterations uses[utf8x]{inputenc}`, so run the other iteration first(giving it a chance to fail) and skip the test only at the second
iteration if needed.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).