Add note on keeping a reference to animation docstrings #18896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I will take advantage of this to once again argue that this behavior should be dropped... |
|
@anntzer Can you point again to the alternative proposal? |
|
I think animations should keep themselves alive even with no other references, just like threads do, per #16221 (comment). The implementation can be #16221 or it can be something less magical than hiding strong refs in lambdas; I'm only arguing about the user-observable behavior here (whether animations get gc'ed or not). |
QuLogic
approved these changes
Nov 6, 2020
|
Well, you can decide that sometime in the future; I'll merge this doc change for now. |
|
@anntzer oh, I remember. I think we have made our standpoints clear in that discussion. If you want to move this further, I think this needs to be brought to the dev call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I intentionally chose a note admonition over the numpydoc
Notessection to make this more prominent. It's a bit on the nose, but it's really something unusual and from the effect alone ("animation is not running") one cannot find the needed solution.Closes #18893.