Added Aria-Labels to all inputs with tooltips for generated HTML animations: issue #17910 #18911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine, but the lines are too long now, as you can see from the flake8 failure. |
|
I'd be ok excluding the line limitation for to the file |
|
Thank you QuLogic and timhoffm for bearing with me on this, something I definitely overlooked, sorry about that. Just updated the flake8 file as tim suggested. Thank you again for the right to the point comments |
timhoffm
approved these changes
Nov 8, 2020
|
Awesome, thank you @xlilos ! Congratulations on your first PR to Matplotlib, hopefully we hear from you againg 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added aria label attributes to generated HTML to increase accessibility for screenreaders.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).