Skip to content

Micro-optimize check_isinstance. #18997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 23, 2020

  • If a single type is passed in, save an iteration over a tuple.
  • Don't compute the type names for the error message unless an error
    actually occurred.

Together, this speeds up _check_isinstance(int, x=1) by more than
2-fold, and _check_isinstance((float, int), x=1) by a few dozen-%.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

- If a single type is passed in, save an iteration over a tuple.
- Don't compute the type names for the error message unless an error
  actually occurred.

Together, this speeds up `_check_isinstance(int, x=1)` by more than
2-fold, and `_check_isinstance((float, int), x=1)` by a few dozen-%.
@timhoffm timhoffm added this to the v3.4.0 milestone Nov 23, 2020
@timhoffm timhoffm merged commit 8768aec into matplotlib:master Nov 23, 2020
@anntzer anntzer deleted the check_isinstance branch November 23, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants