Common __init__ for VPacker and HPacker.
#19012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just inherit the `__init__` from PackerBase, and move the docstring there too. Note that the old defaults (`align=None`, `mode=None`) were invalid values (per `_get_packed_offsets`/`_get_aligned_offsets`), so it seems reasonable to change them to the same valid ones as used by V/HPacker (which are the only subclasses of PackerBase).
timhoffm
approved these changes
Nov 26, 2020
QuLogic
approved these changes
Nov 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just inherit the
__init__from PackerBase, and move the docstringthere too. Note that the old defaults (
align=None,mode=None) wereinvalid values (per
_get_packed_offsets/_get_aligned_offsets), so itseems reasonable to change them to the same valid ones as used by
V/HPacker (which are the only subclasses of PackerBase).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).