Better document multilinebaseline (and other small TextArea fixes) #19015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set its default to False instead of None. (We only check truthiness, so False and None are equivalent.) Also don't explicitly set the default verticalalignment in textprops to "baseline" -- that is already the normal default of `Text`, and is thus redundant; moreover, the old implementation would cause property collision if "verticalalignment" (fully spelt out) was passed in instead (basically, a call to `normalize_kwargs` was missing). Also minor misc. docstring improvements.
timhoffm
approved these changes
Nov 26, 2020
QuLogic
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also set its default to False instead of None. (We only check
truthiness, so False and None are equivalent.)
Also don't explicitly set the default verticalalignment in textprops to
"baseline" -- that is already the normal default of
Text, and is thusredundant; moreover, the old implementation would cause property
collision if "verticalalignment" (fully spelt out) was passed in
instead (basically, a call to
normalize_kwargswas missing).Also minor misc. docstring improvements.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).