Inline MovieWriter._frame_sink. #19045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It plays two fairly different roles in MovieWriter (it's the stdin of
the long-standing ffmpeg-like subprocess) and FileMovieWriter (it's the
ever-changing handle of the frame currently being saved), with different
life-cycles and no reuse between the subclasses, so it's easier to just
inline it at the call site (and skip a comment about how
FileMovieWriter._frame_sink gets closed in grab_frame, hinting at the
tight-coupling between the two of them).
Also, no need to close the process stdin after calling communicate() --
communicate() does it for us.
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).