Skip to content

Always pass integers to wx.Size. #19052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

Always pass integers to wx.Size. #19052

merged 1 commit into from
Dec 16, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 1, 2020

PR Summary

Fixes test failure on Python 3.10, https://bugzilla.redhat.com/show_bug.cgi?id=1902382

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added the GUI: wx label Dec 1, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Dec 1, 2020
@tacaswell
Copy link
Member

Why ceil instead of floor?

@anntzer
Copy link
Contributor

anntzer commented Dec 4, 2020

Why ceil instead of floor?

(It would be nice to document once and for all how floating-point canvas sizes (which can legitimately occur e.g. with vector backends) are supposed to be handled by backends that only support integer sizes (typically raster backends).)

@QuLogic
Copy link
Member Author

QuLogic commented Dec 4, 2020

Because that's what's already done here:

matplotlib/lib/matplotlib/backends/backend_wx.py

Lines 505 to 508 in ff15ca9

FigureCanvasBase.__init__(self, figure)
w, h = map(math.ceil, figure.bbox.size)
# Set preferred window size hint - helps the sizer, if one is connected
wx.Panel.__init__(self, parent, id, size=wx.Size(w, h))

@tacaswell tacaswell merged commit e03d956 into matplotlib:master Dec 16, 2020
@QuLogic QuLogic deleted the wx-int branch December 16, 2020 19:56
@QuLogic
Copy link
Member Author

QuLogic commented Jan 27, 2021

@meeseeksdev backport to v3.3.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 27, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 27, 2021
@tacaswell @meeseeksmachine
Backport PR matplotlib#19052: Always pass integers to wx.Size.
491c957
@QuLogic QuLogic modified the milestones: v3.4.0, v3.3.4 Jan 27, 2021
tacaswell added a commit that referenced this pull request Jan 27, 2021
@tacaswell
Merge pull request #19382 from meeseeksmachine/auto-backport-of-pr-19…
db5b330 
…052-on-v3.3.x

Backport PR #19052 on branch v3.3.x (Always pass integers to wx.Size.)
@QuLogic QuLogic mentioned this pull request Jan 29, 2021
Merged
3 tasks
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
This was referenced Mar 15, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @tacaswell @anntzer @dopplershift