Backport PR #19036 on branch v3.3.x #19062
Merged
+235
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Dec 9, 2020
| echo 'PyGObject is available' || | ||
| echo 'PyGObject is not available' | ||
| # There are no functioning wheels available for OSX 10.12 (as of |
There was a problem hiding this comment.
This comment is no longer relevant (as this is not running on ancient OSX).
I do not think this is a blocker, but we might want to try running this here.
tacaswell
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Note, at some point on
master, the requirements file was renamed fromtravis36minver.txttominver.txt, so I did that in this PR as well to reduce differences between the branches.It also runs slightly different Python versions, since older Python is still supported for this branch.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).