Remove incorrect statement about hist(..., log=True).
#19079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't remove zero-count patches, as can easily be checked with e.g. `print(hist([0, 0, 0, 10], 10, log=True))`. The incorrect statement came in in f24d06c, but it is clear that that patch did not implement that behavior, instead filtering out such patches in `_update_patch_limits`.
QuLogic
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't remove zero-count patches, as can easily be checked with e.g.
print(hist([0, 0, 0, 10], 10, log=True)). The incorrect statementcame in in f24d06c, but it is clear that that patch did not implement
that behavior, instead filtering out such patches in
_update_patch_limits.PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).