Skip to content

Move from cbook._warn_external() to _api.warn_external() #19144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2020
Merged

Move from cbook._warn_external() to _api.warn_external() #19144

merged 2 commits into from
Dec 18, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

Followup of moving all API helpers to matplotlib._api (#18657).

Also use more f-strings in the warning messages to make them shorter more readable.

@timhoffm timhoffm force-pushed the change-warn_external_calls branch from 1c9c162 to 854de08 Compare December 18, 2020 00:04
@timhoffm timhoffm changed the title Move from cbook._warn_deprecated() to _api.warn_deprecated() Move from cbook._warn_external() to _api.warn_external() Dec 18, 2020
@timhoffm timhoffm added this to the v3.4.0 milestone Dec 18, 2020
@timhoffm timhoffm force-pushed the change-warn_external_calls branch from 854de08 to dc42bc8 Compare December 18, 2020 00:18
QuLogic
QuLogic reviewed Dec 18, 2020
View reviewed changes
@timhoffm timhoffm force-pushed the change-warn_external_calls branch from dc42bc8 to ae8af34 Compare December 18, 2020 01:13
QuLogic
QuLogic approved these changes Dec 18, 2020
View reviewed changes
jklymak
jklymak approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to self merge after committing @QuLogic suggestion!

@timhoffm @QuLogic
Fix typo
a8cf13e 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm merged commit f23860d into matplotlib:master Dec 18, 2020
@timhoffm timhoffm deleted the change-warn_external_calls branch December 18, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @jklymak