rework github action jobs #19154
rework github action jobs #19154
Conversation
|
Also fix a missing define for PyPy which will be part of the next release of PyPy, but is currently missing :( |
|
Ahh, I missed that the cibuildwheel job only runs on merges/push to master, so there is no need to test. The second commit
|
|
No wheel of pikepdf is currently available for pypy, and it is painful to build from source. The version of libqpdf available on the build platform is not compatible, and building qpdf from source seems extreme. xref pikepdf/pikepdf#153. So skip it on tests instead. |
|
I disabled the PyPy test run, there were 39 failures. For posterity, as the logs may go away, they are listed below |
| CIBW_MANYLINUX_X86_64_IMAGE: manylinux1 | ||
| CIBW_MANYLINUX_I686_IMAGE: manylinux1 | ||
| CIBW_MANYLINUX_X86_64_IMAGE: manylinux2010 | ||
| CIBW_MANYLINUX_I686_IMAGE: manylinux2010 |
There was a problem hiding this comment.
Is the minimum version of pip we are likly to find in the wild going to recognize manylinux2010 now? Is there any compelling reason to move away from manylinux1?
There was a problem hiding this comment.
I wrote a blog post about it :). manylinux1 is based on CentOS5, which went EOL in 2017. manylinux2010 is based on CentOS6 which is now EOL. The problem was that pip did not keep up. Pip began supporting manylinux2010 wheels with version 19.0, released in Jan 2019. Pip 18 is the version shipped with cpython3.6.12 (the final release), which means users of python3.6 may still have a pip that only recognizes manylinux1 wheels. Users of cpython3.7.3 (released March 2019) and up will have at least pip 19.0, so manylinux2010 is definitely safe for cpython3.9
As for why use a later manylinux: the advantages are bugfixes in the glibc used in the base image, and later versions of the gcc compiler which are not available for Centos5. Some of those bugs are in the math routines, which is why NumPy blocklists older glibc versions.
There was a problem hiding this comment.
This is the default actually, so doesn't need to be specified.
|
This still does not get the aarch64 wheels though correct? |
| CIBW_MANYLINUX_X86_64_IMAGE: manylinux1 | ||
| CIBW_MANYLINUX_I686_IMAGE: manylinux1 | ||
| CIBW_MANYLINUX_X86_64_IMAGE: manylinux2010 | ||
| CIBW_MANYLINUX_I686_IMAGE: manylinux2010 |
There was a problem hiding this comment.
This is the default actually, so doesn't need to be specified.
| - name: Set token | ||
| if: github.event_name == "schedule" | ||
| run: | | ||
| echo "TOKEN=${{ secrets.SCIPY_WHEELS_NIGHTLY_ACCESS }}" >> $GITHUB_ENV; | ||
| echo "ANACONDA_ORG=https://anaconda.org/scipy-wheels-nightly" >> $GITHUB_ENV; | ||
|
|
There was a problem hiding this comment.
Why do you need to set this in the environment if it's passed by argument anyway? These can be used directly in the next step.
| echo "TOKEN=${{ secrets.SCIPY_WHEELS_NIGHTLY_ACCESS }}" >> $GITHUB_ENV; | ||
| echo "ANACONDA_ORG=https://anaconda.org/scipy-wheels-nightly" >> $GITHUB_ENV; | ||
|
|
||
| - name: Upload weekly wheels |
There was a problem hiding this comment.
The regular Upload artifact step should be disabled to not upload to PyPI with the cron job.
There was a problem hiding this comment.
Oops, that's not PyPI, as I do that part. I guess they'll be garbage collected from Actions eventually, so that should be fine.
| libxml2-dev \ | ||
| libxslt1-dev \ |
|
I suspect this is quite out of date re. our current CI setup now - @mattip any desire to rebase this, or is it worth closing? |
|
Might as well close, thanks. |
PR Summary
Related to issue gh-19147
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).