CI: add github action to post to first-time PRs openers #19166
Conversation
.github/workflows/pr_welcom.yml
Outdated
| @@ -0,0 +1,31 @@ | |||
| name: PR Greetings | |||
There was a problem hiding this comment.
Typo in file name: pr_welcom.yml
|
I do not think there is a list anyplace, this should run on any PR opened by a first-time contributor and leave the welcome message. |
Co-authored-by: hannah <story645@gmail.com>
617a618 to
cfc9fc2
Compare
Maybe merge this into your fork's default branch and then have someone open a PR against that? Also, this is a nice thing 👍 to it, especially to the explicit language making clear that it's ok to ping people if it lies dormant. |
|
Maybe also include a mention of https://gitter.im/matplotlib/incubator? This seems like part of the audience you're trying to capture? |
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
Ping @tacaswell : This does not work. See e.g. #19172. https://github.com/matplotlib/matplotlib/pull/19172/checks?check_run_id=1606582798 |
|
I think I was too optomistic about the secrets already being set up. I knew @QuLogic had set one up from the wheels but it looks like it is the wrong name for his to discover and I suspect has the permissions locked down enough that it would not work anyway... |
|
xref actions/first-interaction#10 I'm now confused if we can actually make this work? If it needs access to a secret to post, then that means the secret needs to be available to the PR, which means it is extract able via a malicious PR that adds a task to print out said secret, which means we can not give the action access to the secret, which means the action can not post back to the thread 🤦 . |
|
I thought this was an email to the user, not posted to the PR. |
|
On my first PR to the matplotlib project I did not receive a welcome email, instead my CI build failed. Digging through the logs I found a reference to the welcome message for first-time contributors as a FAIL during the build. It's posted on that PR #19172 that @timhoffm already linked above in this discussion. |
|
@ufmayer Ooops, sorry we made you the guinea pig! This was something new we were trying. Hopefully it is working now. |
|
No problem. If I can help out here let me know, but I guess I can make my first PR only once, and that's done for. |
|
The welcome message is still not working? https://github.com/matplotlib/matplotlib/pull/19187/checks?check_run_id=1619669692 |
|
Tried to fix it, see #19196. |
PR Summary
Not sure how to test this?
Below the line is how I think this should render:
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while please feel free to ping
@matplotlib/developersor anyone who has commented on the PR. Most of our reviewers are volunteers and it is easy for things to fall through the cracks.You can also join us on gitter if real-time discussion would be useful.
For details on testing, write docs, and our review process please see the developer guide
We strive to be a welcoming and open project, please follow our Code of Conduct.