-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make axis.set_scale
private
#1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d adding a wrapper function with depreciation warning.
It seems odd to me that there should be a Thanks for doing this @tacaswell . |
Yeah -- marking as 1.3.x, but I want to think on this for a bit. I can't help thinking there might be a better way. |
Currently all of the calls to My thoughts on this are colored by c++ style friend relationships. I don't see how an |
@@ -683,6 +685,17 @@ def get_scale(self): | |||
return self._scale.name | |||
|
|||
def set_scale(self, value, **kwargs): | |||
""" | |||
Deprecatted 1.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: deprecated
Sorry about the spelling errors, did not realize the spell checker was not working. I copied the import of |
@tacaswell Yes please. That must be a left over when mplDeprecation was in the init.py file. |
Deprecated in PR matplotlib#1917 and commit 4003603
Deprecated in PR matplotlib#1917 and commit 4003603
Addresses fixes #1871 by making
axis.set_scale
private and adding a wrapper function with depreciation warning.