-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Support non-integer bases in mathtext sqrt #19186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1d71821
to
96a2601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d much rather have the tests. 72kb doesn’t seem worth worrying about.
Actually one possibility would be to only test in svg and using In order to render the result correctly, inkscape needs to know the path to Matplotlib fonts. This can either be done by adding "Additional font directories" in the Inkscape GUI under preferences/tools/text, or (I guess that'll be the practical solution for us, which should be reasonably easily automatable) by copying the Matplotlib fonts to e.g. I think the savings may be worth it? Especially as this should allow us to work much more regularly on adding mathtext improvements without being restricted by the baseline images problem at all. |
Can we not merge the new tests with the old ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's decide on #19201 first.
Superseded by #19261. |
PR Summary
Fixes #8665 by using the code snippet proposed there #8665 (comment).
The test images show that it works.
I'm a bit hesitant to add 72kB of images just for testing this. I would also be ok to strip the test again and commit without tests. It's rather unlikely that we'll touch the base part of
sqrt
again and break it.