Clarify Date Format Example #19204
Merged
Clarify Date Format Example #19204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things to fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process please see the developer guide
We strive to be a welcoming and open project, please follow our Code of Conduct.
tacaswell
approved these changes
Dec 30, 2020
|
Thanks @rcomer. Congratulations on your first Matplotlib PR 🎉 hopefully we will hear from you again! |
|
Thanks @tacaswell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses #19203.
As noted there, I had no idea what lines 60-61 were doing, so I've expanded the comment to clarify that. While I was in there, I also:
PR Checklist
I have checked the
flake8, but I'm not 100% sure which of the other tests are relevant here. The guidance makes the testing look a bit too involved to do "just in case" and I'm assuming the CI tests will pick up any problems. Obviously I'm happy to be advised if there is more I should have done here.pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).