Clarify Doc for Secondary axis, ad-hoc example #19249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that the mapping functions for secondary_axis need to be defined beyond the nominal plot range, which requires special care when doing ad-hoc mappings using interpolation functions. Addresses matplotlib#19205
jklymak
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
No worries. That should square it away. |
timhoffm
reviewed
Jan 7, 2021
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
Congratulations on your first contribution to Matplotlib! We hope to see you back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This clarifies that the mapping functions for secondary_axis need to be defined beyond the nominal plot range, which requires special care when doing ad-hoc mappings using interpolation functions.
I've also added a very brief note that at least hints at how to use ad-hoc mapping when defining the interpolation beyond the data range is impractical. I'll be the first to admit it is probably a bit too cryptic as written, but I also didn't want to add a novel.
Addresses #19205
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).