Cleanup and document _plot_args() #19278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7aa29d to
2ba1c58
Compare
2ba1c58 to
acdfe3f
Compare
jklymak
approved these changes
Jan 11, 2021
|
Test failure is unredated (segfault in PyQt). |
QuLogic
reviewed
Jan 12, 2021
| @@ -417,16 +458,16 @@ def _plot_args(self, tup, kwargs, return_kwargs=False): | |||
| raise ValueError("x, y, and format string must not be None") | |||
There was a problem hiding this comment.
This would never have checked whether fmt is None, because of the first if, is it not?
There was a problem hiding this comment.
For (x, y, None), you ended up with the "third arg must be a format string" error. But for (y, None) this check triggers.
There was a problem hiding this comment.
Ah yes, because the length checks are different.
QuLogic
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary