Skip to content

Cleanup code for format processing #19291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

Cleanup code for format processing #19291

merged 1 commit into from
Jan 18, 2021

Conversation

timhoffm
Copy link
Member

PR Summary

Better to be explicit with 'none' and not pretend to have a sentinel, that actually has hidden meaning.

See #19277 (comment) for motivation and context.

@timhoffm timhoffm mentioned this pull request Jan 14, 2021
Merged
@timhoffm timhoffm marked this pull request as draft January 14, 2021 00:38
@timhoffm
Copy link
Member Author

Tests fail with 'none'. Trying 'None'.

@timhoffm timhoffm force-pushed the cleanup-fmt-processing branch from c73d353 to 3de76fa Compare January 14, 2021 00:41
@timhoffm timhoffm mentioned this pull request Jan 14, 2021
Open
@timhoffm timhoffm force-pushed the cleanup-fmt-processing branch from 3de76fa to b8f070e Compare January 14, 2021 22:31
@timhoffm timhoffm marked this pull request as ready for review January 14, 2021 22:34
@timhoffm timhoffm force-pushed the cleanup-fmt-processing branch from b8f070e to 9d4825b Compare January 14, 2021 22:35
anntzer
anntzer approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit lost with the Nones, but clearly this PR is not changing the behavior.

@QuLogic QuLogic merged commit 402fece into matplotlib:master Jan 18, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 18, 2021
@timhoffm timhoffm deleted the cleanup-fmt-processing branch January 19, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @anntzer