Skip to content

DOC: remove stray assignment in "multiple legends" example #19307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Jan 16, 2021

The assignment doesn't have any effect (except for being confusing).

It was most likely added by accident.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but better would be to get rid of all the plt. calls most of which could be replaced by ax. calls...

@mgeier
Copy link
Contributor Author

mgeier commented Jan 16, 2021

OK, but better would be to get rid of all the plt. calls most of which could be replaced by ax. calls...

Sure, feel free to do that, but that's an utterly unrelated change, so there is no reason to couple it with this PR.

@anntzer
Copy link
Contributor

anntzer commented Jan 16, 2021

Let's convert to OO in a separate PR.

@anntzer anntzer merged commit bf0f6cc into matplotlib:master Jan 16, 2021
@mgeier mgeier deleted the patch-1 branch January 17, 2021 11:24
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants