Skip to content

Remove register storage class from Agg files. #19330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Remove register storage class from Agg files. #19330

merged 1 commit into from
Jan 21, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 21, 2021

PR Summary

This storage class has been removed from C++17, and causes a warning when compiling with latest gcc:

warning: ISO C++17 does not allow ‘register’ storage class specifier

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • [n/a] Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Remove register storage class from Agg files.
e8fe99a 
This storage class has been removed from C++17, and causes a warning
when compiling with latest gcc:

```
warning: ISO C++17 does not allow ‘register’ storage class specifier
```
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 21, 2021
@WeatherGod
Copy link
Member

Just to double-check, the AGG stuff is compiled as C++, not C, right? In C, register actually has a useful meaning while in C++ it was semantically indistinguishable from not specifying it.

@QuLogic
Copy link
Member Author

QuLogic commented Jan 21, 2021

All our files are .cpp except for 3, but they do not include any Agg headers.

@WeatherGod WeatherGod merged commit 12ed239 into matplotlib:master Jan 21, 2021
@QuLogic QuLogic deleted the remove-register branch January 21, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
backend: agg Build
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @WeatherGod @anntzer