MarkerStyle is considered immutable #19341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
475462a to
d27ab97
Compare
anntzer
reviewed
Jan 24, 2021
anntzer
reviewed
Jan 24, 2021
d27ab97 to
976823e
Compare
jklymak
reviewed
Jan 25, 2021
| @@ -534,7 +534,7 @@ def set_fillstyle(self, fs): | |||
|
|
|||
| For examples see :ref:`marker_fill_styles`. | |||
| """ | |||
| self._marker.set_fillstyle(fs) | |||
| self.set_marker(MarkerStyle(self._marker.get_marker(), fs)) | |||
There was a problem hiding this comment.
I guess we never test set_fillstyle? Can we use this as the opportunity to do so?
There was a problem hiding this comment.
I'd like to have this deprecation be part of 3.4 and I don't know if I have the bandwidth to add tests soon. Therefore, I'd rather do this in a later PR.
|
As opposed to what I said in the dev call, we cannot easily deprecate Therefore, I'll leave marker and fillstyle as "simple" Matplotlib properties of |
anntzer
approved these changes
Jan 28, 2021
jklymak
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
as discussed in yesterdays dev call.
See also #17850 (comment).