Skip to content

Modify indicate_inset default label value #19378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

Modify indicate_inset default label value #19378

merged 1 commit into from
Jan 28, 2021

Conversation

smartlixx
Copy link
Contributor

PR Summary

This PR closes #19372 by changing the default label of inset axes to '_indicate_inset' from 'indicate_inset', which will prevent a legend entry to be inserted.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak
jklymak approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Normally we'd add a test, but that seems a bit heavy handed for this change...

@jklymak jklymak added this to the v3.4.1 milestone Jan 27, 2021
@QuLogic QuLogic modified the milestones: v3.4.1, v3.4.0 Jan 28, 2021
@QuLogic QuLogic merged commit 99a0960 into matplotlib:master Jan 28, 2021
@smartlixx smartlixx deleted the change_ax_indicate_inset_label branch January 28, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

matplotlib.axes.Axes.indicate_inset default label value is incompatible with LaTeX
3 participants
@smartlixx @QuLogic @jklymak