Always include sample_data in installs. #19383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole sample data folder is ~500K now, which is much less than many compiled extension modules (backend_agg, ft2font, _image, _path, _qhull shared objects all weight ~2-3M). Always installing sample_data is a step towards making Matplotlib installs more homogeneous (i.e., fewer variants).
jklymak
approved these changes
Jan 28, 2021
QuLogic
approved these changes
Jan 28, 2021
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jan 28, 2021
With matplotlib#19383, there's no need to list each `mpl-data` subdirectory individually.
|
@jklymak in particular, yes. |
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole sample data folder is ~500K now, which is much less than many
compiled extension modules (backend_agg, ft2font, _image, _path, _qhull
shared objects all weight ~2-3M). Always installing sample_data is a
step towards making Matplotlib installs more homogeneous (i.e., fewer
variants).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).