Skip to content

Fix empty Poly3DCollections #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Fix empty Poly3DCollections #19399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d2970
Fix depth sorting/drawing of an empty Poly3DCollection.
QuLogic Jan 29, 2021
7facd3f
Add a smoketest that empty 3D scatters do not break.
QuLogic Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/mpl_toolkits/mplot3d/art3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,15 +866,21 @@ def do_3d_projection(self, renderer=None):
else:
cedge = cedge.repeat(len(xyzlist), axis=0)

# sort by depth (furthest drawn first)
z_segments_2d = sorted(
((self._zsortfunc(zs), np.column_stack([xs, ys]), fc, ec, idx)
for idx, ((xs, ys, zs), fc, ec)
in enumerate(zip(xyzlist, cface, cedge))),
key=lambda x: x[0], reverse=True)

zzs, segments_2d, self._facecolors2d, self._edgecolors2d, idxs = \
zip(*z_segments_2d)
if xyzlist:
# sort by depth (furthest drawn first)
z_segments_2d = sorted(
((self._zsortfunc(zs), np.column_stack([xs, ys]), fc, ec, idx)
for idx, ((xs, ys, zs), fc, ec)
in enumerate(zip(xyzlist, cface, cedge))),
key=lambda x: x[0], reverse=True)

_, segments_2d, self._facecolors2d, self._edgecolors2d, idxs = \
zip(*z_segments_2d)
else:
segments_2d = []
self._facecolors2d = np.empty((0, 4))
self._edgecolors2d = np.empty((0, 4))
idxs = []

if self._codes3d is not None:
codes = [self._codes3d[idx] for idx in idxs]
Expand Down
10 changes: 10 additions & 0 deletions lib/mpl_toolkits/tests/test_mplot3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ def test_scatter3d():
x = y = z = np.arange(10, 20)
ax.scatter(x, y, z, c='b', marker='^')
z[-1] = 0 # Check that scatter() copies the data.
# Ensure empty scatters do not break.
ax.scatter([], [], [], c='r', marker='X')


@mpl3d_image_comparison(['scatter3d_color.png'])
Expand Down Expand Up @@ -625,6 +627,14 @@ def test_poly_collection_2d_to_3d_empty():
assert isinstance(poly, art3d.Poly3DCollection)
assert poly.get_paths() == []

fig, ax = plt.subplots(subplot_kw=dict(projection='3d'))
ax.add_artist(poly)
minz = poly.do_3d_projection()
assert np.isnan(minz)

# Ensure drawing actually works.
fig.canvas.draw()


@mpl3d_image_comparison(['poly3dcollection_alpha.png'])
def test_poly3dcollection_alpha():
Expand Down